docs(grid): fix demo date format error #3515
Conversation
WalkthroughThe updates standardize the date format configuration across three grid column components by renaming the property from Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date-composition-api.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.spec.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.vueOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.vue (1)
10-17: SamedateFormat/valueFormatconcern as the Composition API versionReplicate whichever resolution you choose there to keep the two demos in sync.
Also applies to: 22-22
🧹 Nitpick comments (3)
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date-composition-api.vue (1)
31-40: Avoid locale-ambiguous literals in the example dataStoring dates as strings like
'07/02/2024'is ambiguous (US vs EU order) and forces the reader to reverse-engineer the intended pattern. Consider ISO-8601 ('2024-07-02') or numeric timestamps everywhere and rely solely onformat-configfor visual formatting.
This keeps the demo focused on rendering rather than parsing edge-cases.examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.vue (1)
37-45: ISO-8601 input for clearer intentSame remark as above about ambiguous literals; using ISO strings avoids confusion and makes the example safer to copy-paste into different locales.
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.spec.js (1)
6-9: Assert complete, unambiguous strings for all datesGreat update for
date3&date5. For consistency, assert the full string fordate1as well instead of the fragment'-07-02'; fragments can pass even when the actual formatting regresses.-await expect(page.getByText('-07-02').first()).toBeVisible() +await expect(page.getByText('2024-07-02').first()).toBeVisible()This keeps the test deterministic and resilient to unrelated layout/text changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date-composition-api.vue(1 hunks)examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.spec.js(1 hunks)examples/sites/demos/pc/app/grid/renderer/inner-renderer-date.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
examples/sites/demos/pc/app/grid/renderer/inner-renderer-date-composition-api.vue (1)
10-17: Confirm thatdateFormatis the canonical prop nameThe demo switches from
valueFormattodateFormat.⚠️ TinyGridhistorically consumedvalueFormat, so double-check that the underlying renderer has already been upgraded to acceptdateFormat; otherwise the column will silently fall back to its default formatting.If the core component still expects
valueFormat, either:-:format-config="{ dateFormat: 'dd/MM/yyyy' }" +:format-config="{ valueFormat: 'dd/MM/yyyy' }"or expose a compatibility layer in the renderer.
Also applies to: 22-22
PR
修复demo日期格式化问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Tests